Skip to content

bpo-40849: Expose X509_V_FLAG_PARTIAL_CHAIN ssl flag#20463

Merged
miss-islington merged 4 commits intopython:masterfrom
ct-square:add-x509-v-flag-partial
Apr 19, 2021
Merged

bpo-40849: Expose X509_V_FLAG_PARTIAL_CHAIN ssl flag#20463
miss-islington merged 4 commits intopython:masterfrom
ct-square:add-x509-v-flag-partial

Conversation

@l0x-c0d3z
Copy link
Copy Markdown
Contributor

@l0x-c0d3z l0x-c0d3z commented May 27, 2020 •
edited by miss-islington
Loading

This short PR exposes an openssl flag that wasn't exposed. I've also updated to doc to reflect the change. It's heavily inspired by 990fcaa.

https://bugs.python.org/issue40849

Automerge-Triggered-By: GH:tiran

@l0x-c0d3z l0x-c0d3z requested a review from tiran as a code owner May 27, 2020 19:57
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented May 27, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@l0x-c0d3z, @vbr-cts

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@l0x-c0d3z
Copy link
Copy Markdown
Contributor Author

l0x-c0d3z commented May 28, 2020

I've signed the CLA.

ZackerySpytz
ZackerySpytz reviewed Jun 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue on bugs.python.org. Also, this change should have a news entry.

@l0x-c0d3z
Copy link
Copy Markdown
Contributor Author

l0x-c0d3z commented Jun 2, 2020 •
edited
Loading

Bug report created at https://bugs.python.org/issue40849
And I've added the NEWS entry.

@l0x-c0d3z
Copy link
Copy Markdown
Contributor Author

l0x-c0d3z commented Jun 2, 2020

Added myself to ACKS to make patchcheck happy.

@tiran tiran changed the title Expose X509_V_FLAG_PARTIAL_CHAIN ssl flag bpo-40849: Expose X509_V_FLAG_PARTIAL_CHAIN ssl flag Jun 2, 2020
@tiran tiran self-assigned this Jun 2, 2020
@tiran
Copy link
Copy Markdown
Member

tiran commented Jun 3, 2020

@l0x-c0d3z We still don't have your contributor agreement in the database. It's possible that it was not assigned to your GH account correctly.

@csabella
Copy link
Copy Markdown
Contributor

csabella commented Jul 20, 2020

@l0x-c0d3z, please see the previous comments about signing the CLA. Without a signed CLA, this PR will be closed. Thank you.

@csabella csabella added the stale Stale PR or inactive for long period of time. label Jul 20, 2020
@csabella csabella removed the stale Stale PR or inactive for long period of time. label Sep 21, 2020
@csabella
Copy link
Copy Markdown
Contributor

csabella commented Sep 21, 2020

The tool for checking the CLA shows that it is signed, so we'll need to see why the bot keeps flagging it as not signed.

tiran
tiran requested changes Apr 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot does not recognize your CLA. Could you please verify that you used the correct GH account and that the email address from your commit matches GH settings?

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 18, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tiran tiran removed their assignment Apr 18, 2021
@l0x-c0d3z l0x-c0d3z force-pushed the add-x509-v-flag-partial branch from 6f07251 to dc750b7 Compare April 19, 2021 10:43
@l0x-c0d3z
Copy link
Copy Markdown
Contributor Author

l0x-c0d3z commented Apr 19, 2021

Ok, rewrote the commit history to change the emails, and the knights have now given their blessing.

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 19, 2021

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran April 19, 2021 10:44
tiran
tiran approved these changes Apr 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Knight Bedevere is picky.

@miss-islington miss-islington merged commit 64d9752 into python:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

+1 more reviewer

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@l0x-c0d3z @the-knights-who-say-ni @tiran @csabella @bedevere-bot @ZackerySpytz @miss-islington
⚡